Conversation
Author
|
@edwin-benchling For what it's worth, I think it's probably not worthwhile to try to read through the diff in detail or compare it to the original PRs. There are going to be more of these PRs since the upstream project is actively (if slowly) maintained, and they're all going to look like this: very similar to the original PRs, but never identical because there is still divergence on our fork. The project has guaranteed 100% test coverage, so the tests are evidence that the merge is valid. |
edwin-benchling
approved these changes
Jan 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change is only for Benchling's internal use of the package. It merges changes from upstream main to our prod/2.x fork, bringing us to parity with all upstream fixes and new features so far. (This does not mean our fork is now the same as main - there are still areas where we have deliberately made changes for our own use, like removing pdm, plus fixes/features in our fork that have not been accepted to main, like the functional tests.)
The following upstream PRs are included:
Many other changes in the diff are simply replacements of
Dict[T],List[T], etc. withdict[T],list[T], etc. as a style change due to dropping Python 3.8.